Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed docker command in get started doc #1838

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed docker command in get started doc #1838

wants to merge 1 commit into from

Conversation

atilbian
Copy link

@atilbian atilbian commented Jan 10, 2025 •
edited
Loading

What?

It fixes the docker command listed in the Get started documentation following #1536

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).

Related PR(s)/Issue(s)

@atilbian atilbian requested review from heitortsergent and a team as code owners January 10, 2025 10:16
@atilbian atilbian requested review from oleiade and codebien and removed request for a team January 10, 2025 10:16
heitortsergent
heitortsergent approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atilbian thanks for opening the PR! It looks good to me, I'll wait for one of the other reviews to take a look as well before merging this. 🙇

@heitortsergent heitortsergent self-assigned this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heitortsergent heitortsergent heitortsergent approved these changes

@oleiade oleiade Awaiting requested review from oleiade oleiade is a code owner automatically assigned from grafana/k6-core

@codebien codebien Awaiting requested review from codebien codebien is a code owner automatically assigned from grafana/k6-core

Assignees

@heitortsergent heitortsergent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document usage of k6 new command when used in the context of Docker
2 participants
@atilbian @heitortsergent